fix(client): centralize terminal detach so abandoned subscriptions are released - #534

Merged

danshapiro merged 17 commits into

mainfrom

fix/terminal-attach-leak

Jul 25, 2026

Commits on Jul 25, 2026

docs: add implementation plan for terminal-attach-leak

codex
and
microsoft-amplifier
committed
docs(plan): harden terminal-attach-leak plan with load-bearing validation findings

codex
and
microsoft-amplifier
committed
docs(plan): fix two blocking fresheyes findings in terminal-attach-leak plan

codex
and
microsoft-amplifier
committed
docs(plan): fix four blocking fresheyes findings in terminal-attach-leak plan

codex
and
microsoft-amplifier
committed
feat(client): add collectAllTerminalIds layout helper

codex
and
microsoft-amplifier
committed
feat(client): add terminal release-marks module with global test reset

codex
and
microsoft-amplifier
committed
feat(client): add sendTerminalKill helper that marks terminals released

codex
and
microsoft-amplifier
committed
feat(client): add terminalDetachMiddleware releasing dropped terminal references

codex
and
microsoft-amplifier
committed
feat(client): register terminalDetachMiddleware in production store

codex
and
microsoft-amplifier
committed
fix(client): route TabBar close detach through terminalDetachMiddleware

codex
and
microsoft-amplifier
committed
fix(client): route pane-close detach through terminalDetachMiddleware

codex
and
microsoft-amplifier
committed
fix(client): route context-menu detach through terminalDetachMiddleware and mark reopen kill

codex
and
microsoft-amplifier
committed
refactor(client): route remaining terminal.kill sends through sendTerminalKill

codex
and
microsoft-amplifier
committed
test(e2e): assert replace-pane detach from the middleware instead of hand-rolling it

codex
and
microsoft-amplifier
committed
fix(client): gate terminal attach on layout membership to close create-race leak

codex
and
microsoft-amplifier
committed
test(client): align remaining suites with middleware-based terminal detach

codex
and
microsoft-amplifier
committed
docs(client): fix stale comments flagged by final review

codex
and
microsoft-amplifier
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(client): centralize terminal detach so abandoned subscriptions are released - #534

fix(client): centralize terminal detach so abandoned subscriptions are released#534
danshapiro merged 17 commits into
mainfrom
fix/terminal-attach-leak

Commits on Jul 25, 2026

docs: add implementation plan for terminal-attach-leak

docs(plan): harden terminal-attach-leak plan with load-bearing validation findings

docs(plan): fix two blocking fresheyes findings in terminal-attach-leak plan

docs(plan): fix four blocking fresheyes findings in terminal-attach-leak plan

feat(client): add collectAllTerminalIds layout helper

feat(client): add terminal release-marks module with global test reset

feat(client): add sendTerminalKill helper that marks terminals released

feat(client): add terminalDetachMiddleware releasing dropped terminal references

feat(client): register terminalDetachMiddleware in production store

fix(client): route TabBar close detach through terminalDetachMiddleware

fix(client): route pane-close detach through terminalDetachMiddleware

fix(client): route context-menu detach through terminalDetachMiddleware and mark reopen kill

refactor(client): route remaining terminal.kill sends through sendTerminalKill

test(e2e): assert replace-pane detach from the middleware instead of hand-rolling it

fix(client): gate terminal attach on layout membership to close create-race leak

test(client): align remaining suites with middleware-based terminal detach

docs(client): fix stale comments flagged by final review