-
Notifications
You must be signed in to change notification settings - Fork 218
Add app health check support to Dapr Testcontainer #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b458d3
to
cf23e4e
Compare
@artursouza and @cicoyle the build is 🟢 could you please review and approve. @artursouza and @salaboy thanks for the hint related to app check health! |
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
fca6e7e
to
476d363
Compare
@artur-ciocanu amazing stuff |
artursouza
approved these changes
Feb 10, 2025
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 10, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 10, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 10, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 11, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 11, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 11, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 11, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 13, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 13, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 13, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 13, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 13, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 13, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 20, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 20, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 20, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 20, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: Christian Kaps <[email protected]>
salaboy
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 21, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 21, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: Christian Kaps <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 21, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 21, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 21, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: Christian Kaps <[email protected]>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 21, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 21, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: Christian Kaps <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 21, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 21, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 21, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 23, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: Christian Kaps <[email protected]>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 23, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: Christian Kaps <[email protected]>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 23, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: Christian Kaps <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 25, 2025
* Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
dapr-bot
pushed a commit
that referenced
this pull request
Mar 1, 2025
…#1208) * adding spring boot producer Signed-off-by: salaboy <[email protected]> * adding consumer app Signed-off-by: salaboy <[email protected]> * increasing wait for events to popup Signed-off-by: salaboy <[email protected]> * adding readme and examples Signed-off-by: salaboy <[email protected]> * aligning tests for examples Signed-off-by: salaboy <[email protected]> * increasing time out Signed-off-by: salaboy <[email protected]> * adding health check from the sidecar Signed-off-by: salaboy <[email protected]> * feat: Adding basic HTTPEndpoint configuration support in testcontainers module (#1210) * feat: Adding basic HTTPEndpoint configuration support in testcontainers module Signed-off-by: Laurent Broudoux <[email protected]> * feat: #1209 Adding test for HTTPEndpoint in testcontainers module Signed-off-by: Laurent Broudoux <[email protected]> --------- Signed-off-by: Laurent Broudoux <[email protected]> Signed-off-by: salaboy <[email protected]> * updating example Signed-off-by: salaboy <[email protected]> * fixing example Signed-off-by: salaboy <[email protected]> * Add app health check support to Dapr Testcontainer (#1213) * Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]> * commenting reuse Signed-off-by: salaboy <[email protected]> * adding how to run on Kubernetes, unfortunately we need to create containers Signed-off-by: salaboy <[email protected]> * removing subscription and fixing scopes Signed-off-by: salaboy <[email protected]> * adding license headers and logger Signed-off-by: salaboy <[email protected]> * updating logs Signed-off-by: salaboy <[email protected]> * updating READMEs and update_sdk_version for new module Signed-off-by: salaboy <[email protected]> * removing old line Signed-off-by: salaboy <[email protected]> * removing sleeps, using Wait Signed-off-by: salaboy <[email protected]> * updating Kubernetes tutorial to use local registry with KIND, and provide steps to create containers with spring boot Signed-off-by: salaboy <[email protected]> * adding new lines and formatting Signed-off-by: salaboy <[email protected]> * updating reuse and removing comments Signed-off-by: salaboy <[email protected]> * fixing reuse Signed-off-by: salaboy <[email protected]> * removing line break Signed-off-by: salaboy <[email protected]> * fixing custom line breaks Signed-off-by: salaboy <[email protected]> * fixing xml indent to 2 spaces Signed-off-by: salaboy <[email protected]> * Update spring-boot-examples/README.md Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]> * Update spring-boot-examples/README.md Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]> * Update spring-boot-examples/README.md Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]> * Update spring-boot-examples/README.md Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]> * Update spring-boot-examples/README.md Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]> * Update spring-boot-examples/consumer-app/src/test/java/io/dapr/springboot/examples/consumer/ConsumerAppTests.java Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]> * Update spring-boot-examples/producer-app/src/test/java/io/dapr/springboot/examples/producer/TestSubscriberRestController.java Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]> * adding license header to missing files Signed-off-by: salaboy <[email protected]> * adding automated testing for spring boot example Signed-off-by: salaboy <[email protected]> * adding sb examples to the validation pipeline Signed-off-by: salaboy <[email protected]> * updating timeouts Signed-off-by: salaboy <[email protected]> * updating return codes Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Laurent Broudoux <[email protected]> Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: Artur Souza <[email protected]> Co-authored-by: Laurent Broudoux <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: Artur Souza <[email protected]>
dapr-bot
pushed a commit
that referenced
this pull request
Mar 1, 2025
* Add actor testcontainer tests Signed-off-by: Christian Kaps <[email protected]> * adding auto config Signed-off-by: Christian Kaps <[email protected]> * updating ActorClient Signed-off-by: Christian Kaps <[email protected]> * registering? Signed-off-by: Christian Kaps <[email protected]> * updating actors test and actorruntime Signed-off-by: Christian Kaps <[email protected]> * updating ActorRuntime Signed-off-by: Christian Kaps <[email protected]> * Adding WorkflowTaskOptions and use it instead of TaskOptions (#1200) Signed-off-by: Christian Kaps <[email protected]> * Fix formatting issues Signed-off-by: Christian Kaps <[email protected]> * adding spring boot workflows integration (#1195) Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Christian Kaps <[email protected]> * Register workflows and acitivities using instances along classes (#1201) Signed-off-by: Christian Kaps <[email protected]> * feat: Adding basic HTTPEndpoint configuration support in testcontainers module (#1210) * feat: Adding basic HTTPEndpoint configuration support in testcontainers module Signed-off-by: Laurent Broudoux <[email protected]> * feat: #1209 Adding test for HTTPEndpoint in testcontainers module Signed-off-by: Laurent Broudoux <[email protected]> --------- Signed-off-by: Laurent Broudoux <[email protected]> Signed-off-by: Christian Kaps <[email protected]> * fixing actors IT test and messaging IT with app-health-checks Signed-off-by: Christian Kaps <[email protected]> * Add app health check support to Dapr Testcontainer (#1213) * Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: Christian Kaps <[email protected]> * adding license headers + adding wait for actors in test Signed-off-by: Christian Kaps <[email protected]> * Add app health check support to Dapr Testcontainer (#1213) * Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: Christian Kaps <[email protected]> * Picks a port for DaprActorITS for test containers to avoid conflict. Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Christian Kaps <[email protected]> * Add app health check support to Dapr Testcontainer (#1213) * Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <[email protected]> * Some minor cleanup Signed-off-by: Artur Ciocanu <[email protected]> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: Christian Kaps <[email protected]> * using random port thanks to @artur-ciocanu Signed-off-by: Christian Kaps <[email protected]> * Update TestRestController.java Signed-off-by: artur-ciocanu <[email protected]> * Update DaprActorsIT.java Signed-off-by: artur-ciocanu <[email protected]> * Update DaprContainer.java Signed-off-by: artur-ciocanu <[email protected]> --------- Signed-off-by: Christian Kaps <[email protected]> Signed-off-by: Laurent Broudoux <[email protected]> Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Artur Souza <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Co-authored-by: salaboy <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: Laurent Broudoux <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: Artur Souza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although we added support for Dapr Testcontainer sometimes we see race conditions between Dapr daemon and the application that should be run by Dapr. This leads to flaky tests and poor user experience.
The purpose of this PR is to add support for Dapr app health checks. The
DaprContainer
has been enhanced with a new property namedappHealthCheckPath
. If thewithAppHealthCheckPath(...)
builder method is invoked we will add the following CLI args to Dapr daemon:App health checks CLI args are not enough though. What we have observed is that both the app and the Dapr daemon are up and running, but not all the components are setup or ready. We have tried multiple strategies and none of them work correctly. Currently instead of using "dumb"
Thread.sleep(...)
the proposal is to leverage TestcontainerWaitStrategy
to lookout for Dapr logs that tells us when things have been properly bootstrapped. Here is a sample:The downside of this approach is that users will have to add this wait strategy to their tests, but it is definitely better than
Thread.sleep
.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1212
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: