Add checkstyle info on CONTRIBUTING.md #1290
Merged
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matheus Cruz <[email protected]>
artur-ciocanu
approved these changes
Mar 30, 2025
|
@cicoyle and @salaboy I am not sure when the Codecov check has been added, but right now a lot of PRs are failing with code coverage not being met. Do you think we should adjust the code coverage check or should we try to lower the code coverage from 80 to 75 so the check passes. I am not really fond of this idea, but I am not sure how to overcome the current issues. For example the current PR is related to a Markdown file, but the Codecov still fails. |
cicoyle
approved these changes
Mar 31, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1290 +/- ##
============================================
- Coverage 76.91% 75.54% -1.38%
- Complexity 1592 1616 +24
============================================
Files 145 193 +48
Lines 4843 5099 +256
Branches 562 553 -9
============================================
+ Hits 3725 3852 +127
- Misses 821 933 +112
- Partials 297 314 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request has a goal, to add more information about checkstyle configuration.
Issue reference
this PR will close: #1291
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: