Ensure DurableTask classes are hidden in Workflow Runtime package#1311
Merged
cicoyle merged 2 commits intodapr:masterfrom Apr 14, 2025
Merged
Ensure DurableTask classes are hidden in Workflow Runtime package#1311cicoyle merged 2 commits intodapr:masterfrom
cicoyle merged 2 commits intodapr:masterfrom
Conversation
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Contributor
Author
cicoyle
requested changes
Apr 14, 2025
Contributor
cicoyle
left a comment
There was a problem hiding this comment.
thanks for this refactor 🎉 looks great, just one comment for the header
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Contributor
Author
|
@cicoyle the header is fixed. Could you please approve, thank you! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1311 +/- ##
============================================
- Coverage 76.91% 75.38% -1.54%
- Complexity 1592 1605 +13
============================================
Files 145 194 +49
Lines 4843 5090 +247
Branches 562 559 -3
============================================
+ Hits 3725 3837 +112
- Misses 821 933 +112
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to ensure that we hide all the
DurableTask Frameworkrelated classes behindruntimepackage and ensure that we use classes that are free of implementation details.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1310
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: