Skip to content

Removing OkHttp3 dependencies #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

Removing OkHttp3 dependencies #1313

merged 2 commits into from
Apr 14, 2025

Conversation

artur-ciocanu
Copy link
Contributor

Description

The purpose of this PR is to get rid of OkHttp3 so we could simplify dependencies management and ensure that we use as much as we can OOTB functionality from JDK without depending on external libraries.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1312

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Artur Ciocanu <[email protected]>
@artur-ciocanu artur-ciocanu requested review from a team as code owners April 14, 2025 15:23
@artur-ciocanu
Copy link
Contributor Author

@salaboy @mcruzdev and @cicoyle could you please take a look and let me know if we can merge it. Thank you.

@artur-ciocanu
Copy link
Contributor Author

@cicoyle the build is green, except coverage task, could you please review and approve. Thank you!

@cicoyle cicoyle merged commit 128cfde into dapr:master Apr 14, 2025
8 of 9 checks passed
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.42%. Comparing base (d759c53) to head (147af2e).
Report is 127 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1313      +/-   ##
============================================
- Coverage     76.91%   75.42%   -1.50%     
- Complexity     1592     1606      +14     
============================================
  Files           145      194      +49     
  Lines          4843     5090     +247     
  Branches        562      559       -3     
============================================
+ Hits           3725     3839     +114     
- Misses          821      932     +111     
- Partials        297      319      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artur-ciocanu artur-ciocanu deleted the gh-1312 branch April 14, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace OkHttpClient with JDK HttpClient
3 participants