Skip to content

Use Java Bean for connection details and add more tests #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025

Conversation

artur-ciocanu
Copy link
Contributor

Description

This PR adds some cleanup to existing Spring Boot infra.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1316

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artur-ciocanu artur-ciocanu requested review from a team as code owners April 19, 2025 00:07
@artur-ciocanu
Copy link
Contributor Author

@cicoyle and @salaboy this is a tiny PR that should make sure that we use Java Bean spec for our connection details as well as adding proper test coverage to DaprClientAutoconfiguration.

Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Artur Ciocanu <[email protected]>
Copy link
Contributor

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pull request!

Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the alignment with Java Bean patterns and the improved test coverage 🎉

@dapr-bot dapr-bot merged commit de2dc63 into dapr:master Apr 22, 2025
15 of 18 checks passed
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.20%. Comparing base (d759c53) to head (18bc945).
Report is 132 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1317      +/-   ##
============================================
+ Coverage     76.91%   77.20%   +0.29%     
- Complexity     1592     1728     +136     
============================================
  Files           145      200      +55     
  Lines          4843     5283     +440     
  Branches        562      576      +14     
============================================
+ Hits           3725     4079     +354     
- Misses          821      894      +73     
- Partials        297      310      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artur-ciocanu artur-ciocanu deleted the gh-1316 branch April 22, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DaprConnectionDetails for Spring Boot should follow the Java Bean specification
5 participants