-
Notifications
You must be signed in to change notification settings - Fork 215
Use Java Bean for connection details and add more tests #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Artur Ciocanu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Artur Ciocanu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great pull request!
Signed-off-by: Artur Ciocanu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the alignment with Java Bean patterns and the improved test coverage 🎉
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1317 +/- ##
============================================
+ Coverage 76.91% 77.20% +0.29%
- Complexity 1592 1728 +136
============================================
Files 145 200 +55
Lines 4843 5283 +440
Branches 562 576 +14
============================================
+ Hits 3725 4079 +354
- Misses 821 894 +73
- Partials 297 310 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR adds some cleanup to existing Spring Boot infra.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1316
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: