Aligning Spring Boot and SpringFramework versions #1427
Conversation
| @@ -34,8 +34,6 @@ | |||
| <testcontainers.version>1.19.8</testcontainers.version> | |||
| <junit.version>5.11.2</junit.version> | |||
| <dapr.spring.version>0.16.0-SNAPSHOT</dapr.spring.version> | |||
| <springboot.version>3.2.6</springboot.version> | |||
| <springframework.version>6.1.21</springframework.version> | |||
There was a problem hiding this comment.
Nice. This will make our dependency management even more easier.
There was a problem hiding this comment.
yeah.. and it will avoid people approving this kind of PRs: #1424, we should never do that.
| @@ -48,7 +48,10 @@ | |||
| <junit-bom.version>5.11.4</junit-bom.version> | |||
| <snakeyaml.version>2.0</snakeyaml.version> | |||
| <testcontainers.version>1.20.5</testcontainers.version> | |||
| <springboot.version>3.4.3</springboot.version> | |||
| <!-- Do NOT UPGRADE spring.version without checking springboot.version alignment --> | |||
There was a problem hiding this comment.
Quick question, how do we do this ?
There was a problem hiding this comment.
Short answer: mvn dependency:tree on a new project from start.spring.io
|
@salaboy I think this PR will fix the build issue #1425. If you could review this, I can request @artur-ciocanu to merge it and you could pull the changes |
| @@ -165,7 +162,6 @@ | |||
| <dependency> | |||
| <groupId>ch.qos.logback</groupId> | |||
| <artifactId>logback-core</artifactId> | |||
| <version>${logback-core.version}</version> | |||
There was a problem hiding this comment.
we were adding the wrong version (not aligned) for logback core, as this is managed by spring dependencies.
There was a problem hiding this comment.
Can we remove the dependency completely ? Because we don't have a version we don't have to declare it in the dependency management section anymore
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1427 +/- ##
============================================
+ Coverage 76.91% 78.51% +1.59%
- Complexity 1592 1867 +275
============================================
Files 145 230 +85
Lines 4843 5790 +947
Branches 562 601 +39
============================================
+ Hits 3725 4546 +821
- Misses 821 924 +103
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -277,7 +279,6 @@ | |||
| <dependency> | |||
There was a problem hiding this comment.
Can we remove the dependency completely please ? Because we don't have a version we don't have to declare it in the dependency management section anymore
Description
Updating version and aligning with internal SpringFramework deps
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1426
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: