-
Notifications
You must be signed in to change notification settings - Fork 138
Fix/ext pkgs typed #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ext pkgs typed #869
Conversation
Signed-off-by: Casper Nielsen <[email protected]>
Signed-off-by: Casper Nielsen <[email protected]>
|
Do we need to add it to every subfolder too? Like for example in the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
==========================================
+ Coverage 86.63% 87.54% +0.90%
==========================================
Files 84 99 +15
Lines 4473 6461 +1988
==========================================
+ Hits 3875 5656 +1781
- Misses 598 805 +207 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Casper Nielsen <[email protected]>
|
@acroca as long as the |
Signed-off-by: Casper Nielsen <[email protected]>
|
Edit: It's Monday... Disregard what I wrote above. The |
Signed-off-by: Casper Nielsen <[email protected]>
Signed-off-by: Casper Nielsen <[email protected]>
Signed-off-by: Casper Nielsen <[email protected]>
Description
Added
py.typedfor eachdapr.ext.<pkg>to ensure linters find the types. Also removed redundant repo rootpy.typedas it's only needed inside pkg root and there's typed files in each sub folder.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: