fix(dart_frog_cli): route mounting order#1931
Merged
Conversation
eca8834 to
0fc913f
Compare
felangel
commented
Feb 27, 2026
| setup: rm pubspec_overrides.yaml && dart pub global activate --source path ../../packages/dart_frog_cli | ||
| working_directory: examples/kitchen_sink | ||
|
|
||
| docker_custom: |
Contributor
Author
There was a problem hiding this comment.
This is unnecessary and causing our e2e tests to always use the production version of the dart_frog_cli.
felangel
commented
Feb 27, 2026
| resolution: null | ||
| dependency_overrides: {} | ||
| '''), | ||
| resolution: null'''), |
Contributor
Author
There was a problem hiding this comment.
sorting order changes from upstream yaml package
felangel
commented
Feb 27, 2026
| $originalPubspecOverridesContent | ||
| $workspaceRootDartFrogOverride | ||
| equals(''' | ||
| dependency_overrides: |
Contributor
Author
There was a problem hiding this comment.
sorting order changes from upstream yaml package
renancaraujo
approved these changes
Feb 28, 2026
erickzanardo
approved these changes
Feb 28, 2026
|
These fix may introducing a new bug. After update dart_frog_cli to 1.2.14, the generated code create router like this: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Type of Change