Skip to content

Take advantage of wildcards #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Take advantage of wildcards #3266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkgs/dartpad_ui/lib/editor/editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,21 +231,21 @@ class _EditorWidgetState extends State<EditorWidget> implements EditorService {

codeMirror!.on(
'change',
([JSAny? _, JSAny? __, JSAny? ___]) {
([JSAny? _, JSAny? _, JSAny? _]) {
_updateModelFromCodemirror(codeMirror!.getDoc().getValue());
}.toJS,
);

codeMirror!.on(
'focus',
([JSAny? _, JSAny? __]) {
([JSAny? _, JSAny? _]) {
_focusNode.requestFocus();
}.toJS,
);

codeMirror!.on(
'blur',
([JSAny? _, JSAny? __]) {
([JSAny? _, JSAny? _]) {
_focusNode.unfocus();
}.toJS,
);
Expand Down
10 changes: 5 additions & 5 deletions pkgs/dartpad_ui/lib/genai_editing.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class EditorWithButtons extends StatelessWidget {
// Dartdoc help button
ValueListenableBuilder<bool>(
valueListenable: appModel.docHelpBusy,
builder: (_, bool value, __) {
builder: (_, bool value, _) {
return PointerInterceptor(
child: MiniIconButton(
icon: const Icon(Icons.help_outline),
Expand All @@ -70,7 +70,7 @@ class EditorWithButtons extends StatelessWidget {
// Format action
ValueListenableBuilder<bool>(
valueListenable: appModel.formattingBusy,
builder: (_, bool value, __) {
builder: (_, bool value, _) {
return PointerInterceptor(
child: MiniIconButton(
icon: const Icon(Icons.format_align_left),
Expand All @@ -85,11 +85,11 @@ class EditorWithButtons extends StatelessWidget {
// Run action
ValueListenableBuilder(
valueListenable: appModel.showReload,
builder: (_, bool value, __) {
builder: (_, bool value, _) {
if (!value) return const SizedBox();
return ValueListenableBuilder<bool>(
valueListenable: appModel.canReload,
builder: (_, bool value, __) {
builder: (_, bool value, _) {
return PointerInterceptor(
child: ReloadButton(
onPressed: value ? onCompileAndReload : null,
Expand All @@ -103,7 +103,7 @@ class EditorWithButtons extends StatelessWidget {
// Run action
ValueListenableBuilder<CompilingState>(
valueListenable: appModel.compilingState,
builder: (_, compiling, __) {
builder: (_, compiling, _) {
return PointerInterceptor(
child: RunButton(
onPressed:
Expand Down
4 changes: 2 additions & 2 deletions pkgs/dartpad_ui/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ class LoadingOverlay extends StatelessWidget {
final theme = Theme.of(context);
return ValueListenableBuilder<CompilingState>(
valueListenable: appModel.compilingState,
builder: (_, compilingState, __) {
builder: (_, compilingState, _) {
final color = theme.colorScheme.surface;
final compiling = compilingState == CompilingState.restarting;

Expand Down Expand Up @@ -642,7 +642,7 @@ class DartPadAppBar extends StatelessWidget implements PreferredSizeWidget {
child: Center(
child: ValueListenableBuilder<String>(
valueListenable: appModel.title,
builder: (_, String value, __) => Text(value),
builder: (_, String value, _) => Text(value),
),
),
),
Expand Down