Skip to content

Use logging in AOT compiler #4142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srawlins merged 1 commit into from
Dec 22, 2025
Merged

Use logging in AOT compiler #4142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions tool/mustachio/codegen_aot_compiler.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import 'package:analyzer/dart/element/type_provider.dart';
import 'package:analyzer/dart/element/type_system.dart';
import 'package:collection/collection.dart';
import 'package:dart_style/dart_style.dart';
import 'package:dartdoc/src/logging.dart';
import 'package:dartdoc/src/mustachio/annotations.dart';
import 'package:dartdoc/src/mustachio/parser.dart';
import 'package:dartdoc/src/mustachio/renderer_base.dart';
Expand All @@ -32,7 +33,8 @@ Future<String> compileTemplatesToRenderers(
}) async {
var buildData = _BuildData(typeProvider, typeSystem, sourcePath, root);
var referenceUris = <String>{};
print('Compiling ${specs.length} renderer specs into renderer functions...');
logInfo(
'Compiling ${specs.length} renderer specs into renderer functions...');
for (var spec in specs) {
var templatePath = spec.standardHtmlTemplate;
var compiler = await _AotCompiler._readAndParse(
Expand Down Expand Up @@ -113,7 +115,7 @@ Future<void> _deduplicateRenderers(
) async {
var initialRendererCount = rendererCache.rendererCount;
if (initialRendererCount < 2) return;
print('Deduplicating the initial set of $initialRendererCount partial '
logInfo('Deduplicating the initial set of $initialRendererCount partial '
'renderer functions...');

var partialsCompilersToRemove = <_AotCompiler>{};
Expand Down Expand Up @@ -176,7 +178,7 @@ Future<void> _deduplicateRenderers(
if (names.length > 5) {
names = [...names.take(5), '... (${names.length - 5} more)'];
}
print("Could not deduplicate '$templatePath' with context types: "
logInfo("Could not deduplicate '$templatePath' with context types: "
'$contextStackTypes, from ${names.join(', ')}');
// Any partials generated before the exception was thrown are not needed.
markCompilerForRemoval(lubCompiler);
Expand All @@ -202,7 +204,7 @@ Future<void> _deduplicateRenderers(
rendererCache.remove(compiler._templatePath, compiler._usedContextStack);
}

print('Deduplicated down to ${rendererCache.rendererCount} '
logInfo('Deduplicated down to ${rendererCache.rendererCount} '
'partial renderer functions.');
}

Expand All @@ -212,8 +214,8 @@ Future<String> _redirectingMethod(
_AotCompiler compiler, _AotCompiler lubCompiler) async {
var buffer = StringBuffer()..write('String ${compiler._rendererName}');

buffer.writeTypeParameters(compiler._usedContextStack
.expand((c) => c.type.element.typeParameters));
buffer.writeTypeParameters(
compiler._usedContextStack.expand((c) => c.type.element.typeParameters));
buffer.write('(');

for (var context in compiler._usedContextStack) {
Expand Down