Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to incorrect variable names #6428

Closed
wants to merge 4 commits into from
Closed

Fixes to incorrect variable names #6428

wants to merge 4 commits into from
+2,242 −49

Conversation

MiniPiku
Copy link

Key Changes:

  1. refactored 'numbers' to 'digitsSequence'
  2. refactored 'allCharacters' to 'lettersOnly'

@MiniPiku
### Summary of Changes
a2b98a2 
1. Renamed the variable json to data throughout the section.
2. Updated the text to clarify that the example works with deserialized data (e.g., parsed from JSON) rather than raw JSON strings.
3. Ensured consistency in variable naming and explanations.

This update makes the documentation more accurate and avoids misleading readers into thinking that the variable holds a JSON string. If you’re contributing to the Dart documentation, you can submit this change as a pull request to the [site-www repository](https://github.com/dart-lang/site-www)
@MiniPiku
fixed(Indentation): Restored proper spacing in code block
7a12801
@MiniPiku
Key Changes:
dcc9490 
1. refactored 'numbers' to 'digitsSequence'
2. refactored 'allCharacters' to 'lettersOnly'
@MiniPiku MiniPiku mentioned this pull request Feb 17, 2025
Closed
1 task
@MiniPiku
Key Changes:
e26343f 
1. refactored 'numbers' to 'digitsSequence'
2. refactored 'allCharacters' to 'lettersOnly'
@MiniPiku
Copy link
Author

MiniPiku commented Feb 20, 2025 •
edited
Loading

kindly review the updated PR :
https://github.com/dart-lang/site-www/actions/runs/13442271551
thank you

@MiniPiku MiniPiku closed this Feb 21, 2025
@MiniPiku MiniPiku reopened this Feb 21, 2025
@MiniPiku MiniPiku closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MiniPiku