Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthAPI leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with
Unused Dependencies
|
| Package | Status |
|---|---|
| package_config | ❗ Show IssuesThese packages are used outside lib/ but are not dev_dependencies: |
For details on how to fix these, see dependency_validator.
This check can be disabled by tagging the PR with skip-unused-dependencies-check.
License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/bazel_worker/benchmark/benchmark.dart |
| pkgs/coverage/lib/src/coverage_options.dart |
| pkgs/html/example/main.dart |
| pkgs/pubspec_parse/test/git_uri_test.dart |
| pkgs/watcher/test/custom_watcher_factory_test.dart |
This check can be disabled by tagging the PR with skip-license-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check.
Breaking changes ✔️
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| package_config | Breaking | 2.2.0 | 2.3.0-wip | 2.3.0-wip | ✔️ |
This check can be disabled by tagging the PR with skip-breaking-check.
Coverage ⚠️
| File | Coverage |
|---|---|
| pkgs/package_config/example/bin/package_config_of.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
There was a problem hiding this comment.
Code Review
This pull request migrates the package's tests from the legacy test package's expect assertions to the modern checks package. It updates pubspec.yaml dependencies and refactors assertion patterns across several test files (discovery_test.dart, discovery_uri_test.dart, package_config_impl_test.dart, and parse_test.dart). The reviewer suggested improving readability in parse_test.dart by explicitly promoting a nullable variable to non-nullable right after its null check, rather than relying on implicit flow analysis promotion on subsequent property accesses.
| - Adds `PackageConfig.minVersion` to complement `.maxVersion`. | ||
| Currently both are `2`. | ||
|
|
||
| - Uses `package:checks` for testing. |
There was a problem hiding this comment.
No need to document this change. Does not affect users.
No description provided.