[api_summary] Include mixins in textual API summaries#2417
Conversation
Fixes an issue where with mixin clauses were omitted when generating textual API summaries for class and interface declarations. Ports over dart-lang/sdk@1e8a9d5
There was a problem hiding this comment.
Code Review
This pull request adds support for describing mixins in the API summary generator. It extracts the mixins field from InterfaceElement and appends them to the instance description with a 'with' prefix. Additionally, a new test case test_class_mixins has been added to verify this functionality. There are no review comments, and the changes look clean and well-tested.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthAPI leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Unused Dependencies ✔️
For details on how to fix these, see dependency_validator. This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| api_summary | Breaking | 0.0.0 | 0.0.0 | 0.0.0 Report was not created for package:api_summary 0.1.0-wip (dir=/home/runner/work/tools/tools/current_repo/pkgs/api_summary). Error: Error: Exception: Package not available (could not find package api_summary at https://pub.dev). |
This check can be disabled by tagging the PR with skip-breaking-check.
Coverage ✔️
| File | Coverage |
|---|---|
| pkgs/api_summary/lib/src/api_description.dart | 💚 95 % ⬆️ 0 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
Is there work ongoing to get to a single SoT? |
Yep! This is needed so I can delete the internal bits (without regressing!) |
Fixes an issue where with mixin clauses were omitted when generating textual API summaries for class and interface declarations.
Ports over dart-lang/sdk@1e8a9d5