towsg84 and tomercator unit [Improve helpers.dart with better documentation and code style] #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update documentation to use proper Dart doc syntax with types in [] - Convert var to final where appropriate - Maintain consistent documentation style across the codebase - Improve readability of function parameter documentation
- Removed lib/src/point_on_feature.dart - Removed lib/point_on_feature.dart - Removed benchmark/point_on_feature_benchmark.dart - Removed test/components/point_on_feature_test.dart These files are now part of the point_on_feature_final branch and pull request
lukas-h
requested changes
Apr 18, 2025
- Updated convertCoordinates, toMercator, and toWGS84 functions to use Position type instead of List - Added proper altitude preservation during coordinate conversions - Improved error handling with ArgumentError and descriptive messages - Added tests to verify conversions and altitude preservation - Updated Progress.md to mark functions as implemented
|
Just want to confirm - Did you want me to merge the testing file "helpers.test" into meta.test as that would be best practice? and therefore add it onto the next branch that requires it and continue adding it on? As @aardrop mentioned in the discord? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added toWGS84 and toMercator as member functions of the coordinate types in the helper file