Skip to content

test: add CRM admin Playwright coverage - #10

Merged
darwvin-dev merged 1 commit into
darwvin-dev:mainfrom
wyf027:test/admin-crm-playwright
Jun 16, 2026
Merged

test: add CRM admin Playwright coverage#10
darwvin-dev merged 1 commit into
darwvin-dev:mainfrom
wyf027:test/admin-crm-playwright

Conversation

@wyf027

@wyf027 wyf027 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add self-contained Playwright tests for the generated CRM admin workflow
  • cover login, resource listing, search, filtering, create/update, and audit log visibility
  • add local e2e package metadata, TypeScript config, and failure screenshots/traces/videos

Closes #4

Tests

  • npm --prefix tests/e2e run typecheck
  • npm --prefix tests/e2e test -- --list
  • npm --prefix tests/e2e run test:local -- --list
  • go test ./...

Note: I did not run the full browser suite because it requires a generated Next.js app server at the configured base URL.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec8b29cb20

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/e2e/admin.spec.ts

await page.getByPlaceholder("Search users").fill("")
await page.getByLabel("Clear filter").click()
await page.getByRole("combobox").first().selectOption("status")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Scope the filter combobox locator

On resource pages the generated AdminShell renders its tenant selector before the grid, so getByRole("combobox").first() targets the header tenant dropdown, not the filter-field dropdown. In the searches and filters the resource list test this makes selectOption("status") fail because the tenant selector only contains tenant options; scope the locator to the grid/filter controls or give the filter select an accessible label.

Useful? React with 👍 / 👎.

@darwvin-dev
darwvin-dev merged commit bbf0859 into darwvin-dev:main Jun 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Playwright e2e tests for the CRM demo

2 participants