fix(dashpay): keep marketplace sheets alive during PIN auth - #1066
Merged
Conversation
|
Warning Review limit reachedNext included review available in 30 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Secondary username registration could not complete with wallet PIN authentication. The registration sheet dismissed as soon as the asynchronous action started, which removed the SwiftUI/UIKit presentation host while the PIN controller was still being presented. The authentication controller then failed before the user could enter the PIN. Face ID usually completed quickly enough to avoid the race.
What was done?
How Has This Been Tested?
dashpayDebug scheme from the rebased PR revision for an iOS 26.5 iPhone 17 Pro simulator.org.dashfoundation.dash; verified the process remained alive after stabilization.Authentication failed.Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
This pull request was created by Codex.