Skip to content

fix(dashpay): keep marketplace sheets alive during PIN auth - #1066

Merged
romchornyi merged 1 commit into
developfrom
t3code/fix-username-pin-auth
Aug 26, 2026
Merged

fix(dashpay): keep marketplace sheets alive during PIN auth#1066
romchornyi merged 1 commit into
developfrom
t3code/fix-username-pin-auth

Conversation

@PastaPastaPasta

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Secondary username registration could not complete with wallet PIN authentication. The registration sheet dismissed as soon as the asynchronous action started, which removed the SwiftUI/UIKit presentation host while the PIN controller was still being presented. The authentication controller then failed before the user could enter the PIN. Face ID usually completed quickly enough to avoid the race.

What was done?

  • Keep marketplace action sheets attached through authentication and Platform execution.
  • Dismiss sheets only after the operation succeeds.
  • Disable interactive sheet dismissal while an action is running.
  • Keep progress visible in the active sheet during authentication and execution.
  • Apply the lifecycle-safe behavior consistently to registration, contested-name requests, purchases, listings, delisting, and transfers.

How Has This Been Tested?

  • Built the dashpay Debug scheme from the rebased PR revision for an iOS 26.5 iPhone 17 Pro simulator.
  • Installed and launched org.dashfoundation.dash; verified the process remained alive after stabilization.
  • Manually completed the secondary username registration flow using PIN authentication on a simulator without Face ID; registration succeeded without Authentication failed.
  • Performed a self-review covering success, cancellation, and error paths.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

This pull request was created by Codex.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 30 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ed2b103c-3775-40da-bb93-8e681d1612ba

📥 Commits

Reviewing files that changed from the base of the PR and between 738022e and e9462f2.

📒 Files selected for processing (1)
  • DashWallet/Sources/UI/Explore Dash/UsernameMarketplaceScreen.swift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@romchornyi romchornyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romchornyi
romchornyi merged commit 0e243a9 into develop Aug 26, 2026
2 checks passed
@romchornyi
romchornyi deleted the t3code/fix-username-pin-auth branch August 26, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants