Skip to content

chore: update evo sdk 4.2-dev - #77

Open
thephez wants to merge 2 commits into
dashpay:masterfrom
thephez:update-deps/evo-sdk-4.2-dev
Open

chore: update evo sdk 4.2-dev#77
thephez wants to merge 2 commits into
dashpay:masterfrom
thephez:update-deps/evo-sdk-4.2-dev

Conversation

@thephez

@thephez thephez commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

thephez and others added 2 commits August 27, 2026 11:52
Regenerated documentation picks up the new `timeRange` bucket-selection parameter on document queries.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Prevents false failures when installing a range/tag
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 91d51dd9-7b55-483d-ba72-732cf1da43ef


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

⛔ Blockers found — Opus deferred (commit 287f472)
Canonical validated blockers: 1

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review — Codex only

The SDK bump resolves to 4.2.0-dev.2, but declaring it through the 4.2-dev dist-tag breaks the repository's scheduled stable-version updater. Pinning the resolved prerelease version preserves the intended upgrade while keeping automated updates functional. Source: Codex reviewer backend model ID was not provided in the supplied evidence; final Claude verifier backend model ID was not exposed; openclaw-agent/cliproxy/gpt-5.6-sol is orchestration-only and not reviewer evidence.

Validated blockers were found in the Codex precheck. Opus is deferred until a fresh Codex revalidation clears the blocker gate.

Review provenance

  • Codex reviewers: gpt-5.6-sol — general (completed)
  • Verifier: gpt-5.6-sol — verifier
  • Sonnet: not run (deferred by blocker gate)

🔴 1 blocking

🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `package.json`:
- [BLOCKING] package.json:4: Keep the SDK dependency as an exact semver version
  The scheduled updater reads this dependency value and supplies it to the semver CLI as `>$CURRENT_VERSION` in `.github/workflows/update-evo-sdk.yml:58`. The resulting range, `>4.2-dev`, is invalid: the installed semver CLI returns no output and a nonzero status for both `4.2.0` and `4.3.0`. Because the workflow suppresses that status with `|| true`, it records `needs_update=false`, so it will not upgrade this repository when 4.2.0 or a later stable release becomes npm's latest version. Pin the exact 4.2.0-dev.2 version already resolved in `yarn.lock`; the updated unit test can still read and verify the installed package version.

Comment thread package.json
"private": true,
"dependencies": {
"@dashevo/evo-sdk": "4.1.1"
"@dashevo/evo-sdk": "4.2-dev"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Blocking: Keep the SDK dependency as an exact semver version

The scheduled updater reads this dependency value and supplies it to the semver CLI as >$CURRENT_VERSION in .github/workflows/update-evo-sdk.yml:58. The resulting range, >4.2-dev, is invalid: the installed semver CLI returns no output and a nonzero status for both 4.2.0 and 4.3.0. Because the workflow suppresses that status with || true, it records needs_update=false, so it will not upgrade this repository when 4.2.0 or a later stable release becomes npm's latest version. Pin the exact 4.2.0-dev.2 version already resolved in yarn.lock; the updated unit test can still read and verify the installed package version.

Suggested change
"@dashevo/evo-sdk": "4.2-dev"
"@dashevo/evo-sdk": "4.2.0-dev.2"

source: ['codex']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants