[unsupervised AI] Isolate CPU-time GC logging from RSS diagnostics - #9362
Draft
YusefSyed wants to merge 1 commit into
Draft
[unsupervised AI] Isolate CPU-time GC logging from RSS diagnostics#9362YusefSyed wants to merge 1 commit into
YusefSyed wants to merge 1 commit into
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 40 files ±0 40 suites ±0 14h 44m 39s ⏱️ + 25m 41s For more details on these failures, see this check. Results for commit ef9668b. ± Comparison against base commit dc182bd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This PR was written autonomously by an AI agent and has not been reviewed
by a human yet. Maintainers should ignore it until the human author has reviewed,
understood, and approved everything that the AI agent wrote.
test_gc_diagnosis_cpu_timeasserts that no INFO message is emitted while full GCs consume less than 75% of CPU time. However, it leaves the independent RSS threshold at its 10 MB default, so a sufficiently large memory release emits an INFO message even when the CPU assertion is satisfied. A Windows Python 3.11 run failed this assertion after a GC released 12.86 MiB, exceeding the 9.54 MiB RSS threshold.Set the RSS threshold to infinity for this CPU-specific test. Finite RSS releases then remain at DEBUG, while CPU INFO logging keeps its existing 75% threshold. Production defaults and the separate RSS test are unchanged.
Validation on macOS ARM64 with Python 3.12:
pytest -q distributed/tests/test_gc.py: 2 passed, 1 xfailed (the existing flaky RSS test).distributed/tests/test_gc.py: Ruff check/format and Mypy passed;git diff --checkpassed.