MAINT: Don't use Backend for delegation
#265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
changed the title
Backend for delegationBackend for delegation
lucascolley
reviewed
Apr 15, 2025
Co-authored-by: Lucas Colley <[email protected]>
lucascolley
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #221 (comment)
Do not use the
Backendenum outside of testing.This enum contains a lot of "backends" that are just variant duplicates, which is an artifact of using this enum to parametrize the
xpfixture. Which is a decent hack for pytest, but which doesn't make any sense in the context of the dispatch system.This also allows for quite a bit of simplification without adding any weight to the delegate module itself.