Skip to content

Update all contributors #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2023
Merged

Conversation

steff456
Copy link
Member

@steff456 steff456 commented Apr 7, 2023

This PR fixes #516

  • Updates the readme in this repository to add new contributors

Questions

  • I'm unsure on what was the initial criteria for the emojis for each contributor, do we have a preference? (note: all the contributors added in this PR are people that have at least 1 commit in this repo)

@steff456 steff456 added the Maintenance Bug fix, typo fix, or general maintenance. label Apr 7, 2023
@steff456 steff456 requested a review from rgommers April 7, 2023 18:15
@steff456 steff456 self-assigned this Apr 7, 2023
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure on what was the initial criteria for the emojis for each contributor, do we have a preference?

This is a matter of judgement, you can't automate it. Ideas, Planning, & Feedback seems reasonable for most folks, when they've contributed to discussions/decisions. There are others possible of course; this should be clear from existing entries.

(note: all the contributors added in this PR are people that have at least 1 commit in this repo)

Can you please check open PRs too? And I'll send you a few more on Slack.

@steff456
Copy link
Member Author

The last commit included people that opened issues in both the array-api and testing repos. I'm waiting for one confirmation and after that this PR will be ready to merge.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steff456, this looks good to me now. I'll give it a day or two, and then hit the green button if there are no more comments or suggested additions.

@rgommers rgommers merged commit 4d1372b into data-apis:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all-contributors
2 participants