Skip to content

fix(pf4): wix wizard buttons layout #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Conversation

Hyperkid123
Copy link
Member

Description
Fixes the button's layout and spacing.

Checklist: (please see documentation page for more information)

  • Yarn build passes
  • Yarn lint passes
  • Yarn test passes
  • Test coverage for new code (if applicable)
  • Documentation update (if applicable)
  • Correct commit message
    • format fix|feat({scope}): {description}
    • i.e. fix(pf3): wizard correctly handles next button
    • fix will release a new _._.X version
    • feat will release a new _.X._ version (use when you introduce new features)
      • we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
    • scope: package
    • if you update the documentation or tests, do not use this format
      • i.e. Fix button on documenation example page

Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 11:49am

Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.27%. Comparing base (e8c7ce2) to head (7208a81).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...apper/src/wizard/wizard-components/step-buttons.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1507   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files         185      185           
  Lines        3389     3389           
  Branches     1462     1462           
=======================================
  Hits         3195     3195           
  Misses        194      194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hyperkid123 Hyperkid123 merged commit 322ed37 into master May 6, 2025
5 of 6 checks passed
@Hyperkid123 Hyperkid123 deleted the pf4-wizard-footer branch May 6, 2025 12:07
@rvsia rvsia added the released label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants