ci(bindings): restore nodejs windows builds - #789
Merged
youngsofun merged 2 commits intoJul 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
databend-driverdeclares Windows native packages in its NAPI target list, but the Node.js binding workflow was not building thewin32-msvcartifacts. That allowed the main npm package to reference optional Windows packages that were never published, which breaks Yarn Classic dependency resolution even on non-Windows platforms.The previous Windows matrix was disabled due to a Corepack/setup-node issue. This change avoids Corepack for the Node.js binding workflows by using
pnpm/action-setup, then restores the Windows build targets so the npm release can include the declared Windows packages.Summary
pnpm/action-setup@v4in Node.js binding CI and npm publishing.x86_64-pc-windows-msvcandaarch64-pc-windows-msvcNode.js binding build targets.0.34.2so the release workflow publishes a complete package graph.Testing
git diff --check