Skip to content

ci(bindings): restore nodejs windows builds - #789

Merged
youngsofun merged 2 commits into
databendlabs:mainfrom
youngsofun:codex/fix-nodejs-windows-publish
Jul 16, 2026
Merged

ci(bindings): restore nodejs windows builds#789
youngsofun merged 2 commits into
databendlabs:mainfrom
youngsofun:codex/fix-nodejs-windows-publish

Conversation

@youngsofun

@youngsofun youngsofun commented Jul 15, 2026

Copy link
Copy Markdown
Member

Motivation

databend-driver declares Windows native packages in its NAPI target list, but the Node.js binding workflow was not building the win32-msvc artifacts. That allowed the main npm package to reference optional Windows packages that were never published, which breaks Yarn Classic dependency resolution even on non-Windows platforms.

The previous Windows matrix was disabled due to a Corepack/setup-node issue. This change avoids Corepack for the Node.js binding workflows by using pnpm/action-setup, then restores the Windows build targets so the npm release can include the declared Windows packages.

Summary

  • Replace Corepack setup with pnpm/action-setup@v4 in Node.js binding CI and npm publishing.
  • Restore x86_64-pc-windows-msvc and aarch64-pc-windows-msvc Node.js binding build targets.
  • Bump the workspace and Node.js package versions to 0.34.2 so the release workflow publishes a complete package graph.

Testing

  • git diff --check
  • Node.js binding workflow should build Linux, macOS, and Windows artifacts in CI.

@youngsofun
youngsofun merged commit 8bc5e01 into databendlabs:main Jul 16, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant