fix(python): expose cursor write statistics - #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerStatsfrom the blocking cursor query stream instead of dropping stats eventswrite_progress.rowsthrough DB-APIcursor.rowcountcursor.statsexecutemanyrowcount/statistics consistent withexecuteCloses #790.
Verification
cargo fmt --all -- --checkcargo check -p databend-pythoncargo test -p databend-python --libcd bindings/python && uv run ruff format --check package/databend_driver/__init__.pyi tests/cursor/steps/binding.pygit diff --checkNot Run
make integration-bindings-pythonwas attempted, but Docker could not pull images because the daemon proxy points to unavailable127.0.0.1:1090.cargo clippy -p databend-python --all-targets --all-features -- -D warningswas attempted, but it fails on the pre-existing unusedchrono::FixedOffsetimport inbindings/python/src/types.rs.