feat: database level default connection configuration #18886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements database-level default storage connection configuration allowing databases to specify default connection settings that tables automatically inherit during creation. Key features: - CREATE DATABASE OPTIONS syntax with DEFAULT_STORAGE_CONNECTION and DEFAULT_STORAGE_PATH - ALTER DATABASE SET OPTIONS for updating connection defaults - Automatic table inheritance of database defaults during CREATE TABLE - Paired validation requiring both connection and path options together - Tables can override database defaults with explicit table-level connection options
This commit completes the database-level default connection configuration feature allowing databases to specify default storage connection settings for FUSE tables. Key changes: - Fix table inheritance logic: FUSE tables inherit database defaults - Add ALTER DATABASE SET OPTIONS with paired validation - Implement privilege checking for ALTER DATABASE operations - Add comprehensive SQL logic tests for feature validation The feature enables: - CREATE DATABASE OPTIONS (DEFAULT_STORAGE_CONNECTION = '...', DEFAULT_STORAGE_PATH = '...') - ALTER DATABASE SET OPTIONS with paired validation (both options required) - FUSE tables automatically inherit database connection defaults for external storage Corrected inheritance logic where FUSE tables (external storage capable) inherit database defaults, while other engines use their own connection mechanisms.
github-actions
bot
added
the
pr-feature
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
to be detailed
Tests
Type of change
This change is