Skip to content

feat(query): the HTTP protocol supports returning a body in arrow IPC format #18890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 28, 2025
Merged

feat(query): the HTTP protocol supports returning a body in arrow IPC format #18890

merged 11 commits into from
Oct 28, 2025

Conversation

@forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Oct 25, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Direct transmission of arrow data can simplify client driver implementation.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Oct 25, 2025
@forsaken628
Copy link
Collaborator Author

Another option is to transmit in Parquet format, which requires minimal code modification. We can test and compare the results.

sundy-li
sundy-li reviewed Oct 25, 2025
View reviewed changes
@forsaken628 forsaken628 marked this pull request as ready for review October 27, 2025 03:59
@BohuTANG
Copy link
Member

@codex

@sundy-li
Copy link
Member

sundy-li commented Oct 28, 2025 •
edited
Loading

Could we use it in tests/sqllogictests/src/client/http_client.rs? Choose JSON/arrow randomly in each request

@BohuTANG BohuTANG merged commit b8b06d6 into databendlabs:main Oct 28, 2025
87 checks passed
@forsaken628 forsaken628 deleted the arrow-body branch October 28, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sundy-li sundy-li sundy-li approved these changes

@youngsofun youngsofun Awaiting requested review from youngsofun

Assignees

No one assigned

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@forsaken628 @BohuTANG @sundy-li