Skip to content

Fix FlowAppendView support for 'once' flag by forcing batch read #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liamperritt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix FlowAppendView support for 'once' flag by forcing batch read #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/dataflow/flows/append_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def columnPrefixExceptions(self) -> List[str]:

@property
def once(self) -> bool:
"""Get the once flag."""
"""Get the once flag. Note: Setting 'once' requires a batch read."""
return self.flowDetails.get("once", False)

def create_flow(
Expand All @@ -55,14 +55,17 @@ def get_column_prefix_exceptions(flow_config: FlowConfig) -> List[str]:
return column_prefix_exceptions

spark = self.spark
spark_reader = spark.readStream
if self.once:
spark_reader = spark.read
exclude_columns = flow_config.exclude_columns
column_prefix_exceptions = get_column_prefix_exceptions(flow_config)

source_view_name = f'live.{self.sourceView}'

@dp.append_flow(name=self.flowName, target=self.targetTable, once=self.once)
def flow_transform():
df = spark.readStream.table(source_view_name)
df = spark_reader.table(source_view_name)
if "column_prefix" in self.flowDetails:
prefix = f"{self.columnPrefix.lower()}_"
df = df.select([
Expand Down