Skip to content

Enable native geospatial type support by default#1446

Merged
sreekanth-db merged 5 commits into
mainfrom
enable-geospatial-by-default
May 13, 2026
Merged

Enable native geospatial type support by default#1446
sreekanth-db merged 5 commits into
mainfrom
enable-geospatial-by-default

Conversation

@sreekanth-db
Copy link
Copy Markdown
Collaborator

Summary

  • Changes EnableGeoSpatialSupport default from 0 to 1 so getObject() returns IGeometry/IGeography instances instead of raw EWKT strings out of the box.
  • Users can set EnableGeoSpatialSupport=0 to restore the previous behavior.

Test plan

  • Run GeospatialTests E2E suite (all 48 configurations) — verified locally, all pass
  • Verified default behavior across all 6 protocol/serialization/CloudFetch combinations: geospatial objects returned in all modes except Thrift+Inline (expected)
  • Existing tests unaffected since they explicitly set the flag

This pull request and its description were written by Isaac.

Change EnableGeoSpatialSupport default from "0" to "1" so getObject()
returns IGeometry/IGeography instances instead of raw EWKT strings.
Users can set EnableGeoSpatialSupport=0 to restore the previous behavior.

Co-authored-by: Isaac
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
@sreekanth-db sreekanth-db requested a review from gopalldb May 13, 2026 09:55
Comment thread NEXT_CHANGELOG.md Outdated
### Added

### Updated
- Enabled native geospatial type support (`GEOMETRY` and `GEOGRAPHY`) by default. `getObject()` now returns `IGeometry`/`IGeography` instances instead of EWKT strings. Set `EnableGeoSpatialSupport=0` to restore the previous behavior.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

highlight as breaking

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved the entry to breaking changes section

Update expected metadata from STRING to GEOMETRY(0)/GEOGRAPHY(0) since
EnableGeoSpatialSupport now defaults to enabled.

Co-authored-by: Isaac
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
ST_GeogFromText defaults to WGS 84 (SRID 4326), not 0.

Co-authored-by: Isaac
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
Co-authored-by: Isaac
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
Geospatial support now defaults to enabled, update assertion accordingly.

Co-authored-by: Isaac
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
@sreekanth-db sreekanth-db merged commit 547b38f into main May 13, 2026
15 checks passed
@sreekanth-db sreekanth-db deleted the enable-geospatial-by-default branch May 13, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants