Add revocation checking, trust anchor validation, and trust store type detection (PR 3 of 3)#787
Merged
Conversation
vikrantpuppala
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the extended SSL functionality including revocation checking, trust anchor validation, and fallback logic. It also includes improvements to error handling and deeper test coverage.
Flow explanation: https://docs.google.com/document/d/1TSfUsci3n9dXzXcnaYCNG7i7bmQo-PkXBQY1QrHzkpg/edit?tab=t.0#heading=h.ofrwhzeixs4q
Changes
ConfiguratorUtilsTestwith extended test casesTesting
All unit tests pass with full trust-store validation and revocation paths. Extended integration tests validate cert behavior and proxy scenarios.
Did manual testing for 5 key scenarios:
Additional Notes to the Reviewer
Depends on PR #786
Final PR for the SSL configuration enhancement work.