Skip to content

Add revocation checking, trust anchor validation, and trust store type detection (PR 3 of 3)#787

Merged
madhav-db merged 53 commits into
mainfrom
ssl-tests-and-ci
Apr 28, 2025
Merged

Add revocation checking, trust anchor validation, and trust store type detection (PR 3 of 3)#787
madhav-db merged 53 commits into
mainfrom
ssl-tests-and-ci

Conversation

@madhav-db
Copy link
Copy Markdown
Collaborator

@madhav-db madhav-db commented Apr 11, 2025

Description

This PR implements the extended SSL functionality including revocation checking, trust anchor validation, and fallback logic. It also includes improvements to error handling and deeper test coverage.

Flow explanation: https://docs.google.com/document/d/1TSfUsci3n9dXzXcnaYCNG7i7bmQo-PkXBQY1QrHzkpg/edit?tab=t.0#heading=h.ofrwhzeixs4q

Changes

  • Implement certificate revocation checking and trust anchor validation
  • Add support for auto-detection of trust store types
  • Improve error messages for missing or invalid trust store paths
  • Add fallback to default trust stores with revocation configuration
  • Update ConfiguratorUtilsTest with extended test cases
  • Add coverage for invalid anchors, type fallbacks, and precedence behavior

Testing

All unit tests pass with full trust-store validation and revocation paths. Extended integration tests validate cert behavior and proxy scenarios.

Did manual testing for 5 key scenarios:

  1. Vanilla scenario
  2. Custom Trust Store
  3. System Trust Store
  4. AllowSelfSignedCerts
  5. Invalid trust store

Additional Notes to the Reviewer

Depends on PR #786
Final PR for the SSL configuration enhancement work.

@madhav-db madhav-db changed the title Add Comprehensive SSL Testing Framework Add Comprehensive SSL Testing Framework (PR 3 of 3) Apr 11, 2025
Comment thread NEXT_CHANGELOG.md Outdated
Comment thread src/main/java/com/databricks/jdbc/dbclient/impl/common/ConfiguratorUtils.java Outdated
@madhav-db madhav-db merged commit 8b1e4df into databricks:main Apr 28, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants