-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] Make databricks-sdk-py compliant with PEP 621 and PEP 625 #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaudhartert-db
approved these changes
Feb 20, 2025
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
We've received messages from PyPI that the current SDK library is not compliant with PEP 625. With help from the administrators at PyPI, I've converted our
setup.py
to apyproject.toml
and, with help from the setuptoolsbuild
frontend, we can produce PEP 625-compliant artifacts.Additionally, we can run
check-manifest
to verify that our source distribution and wheel contain the same set of files. I noticed in particular that all of our examples and docs are included in both our wheel and sdist, polluting customer's python environments with unnecessary packages.How is this tested?
Ran
python -m build
and saw that the desired build artifacts were produced.The
check-manifest
job should be passing.Tested uploading the resulting artifact to Test PyPI: https://github.com/databricks/databricks-sdk-py/actions/runs/13438801138/job/37547674236
NO_CHANGELOG=true