Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Make databricks-sdk-py compliant with PEP 621 and PEP 625 #895

Merged
merged 9 commits into from
Feb 20, 2025

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Feb 20, 2025

What changes are proposed in this pull request?

We've received messages from PyPI that the current SDK library is not compliant with PEP 625. With help from the administrators at PyPI, I've converted our setup.py to a pyproject.toml and, with help from the setuptools build frontend, we can produce PEP 625-compliant artifacts.

Additionally, we can run check-manifest to verify that our source distribution and wheel contain the same set of files. I noticed in particular that all of our examples and docs are included in both our wheel and sdist, polluting customer's python environments with unnecessary packages.

How is this tested?

Ran python -m build and saw that the desired build artifacts were produced.

The check-manifest job should be passing.

Tested uploading the resulting artifact to Test PyPI: https://github.com/databricks/databricks-sdk-py/actions/runs/13438801138/job/37547674236

NO_CHANGELOG=true

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 895
  • Commit SHA: d469ed38462757a69b1194059635f603f336184d

Checks will be approved automatically on success.

@mgyucht mgyucht enabled auto-merge February 20, 2025 16:20
@mgyucht mgyucht added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 83a921f Feb 20, 2025
19 of 20 checks passed
@mgyucht mgyucht deleted the pep-625 branch February 20, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants