Skip to content

Fix boolean transformer for falsey values. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattmess1221 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix boolean transformer for falsey values. #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pgsqlite/pgsqlite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,12 @@ async def sem_task(coro):
return await asyncio.gather(*(sem_task(coro) for coro in coros))

def boolean_transformer(self, val: Any, nullable: bool) -> Union[bool, None]:
if nullable and not val:
if nullable and val is None:
return None
if not nullable and not val:
if not nullable and val is None:
raise Exception("Value is None but column is not nullable")

if val == 1 or val.lower() == "true":
if val == 1 or str(val).lower() == "true":
return "TRUE"
return "FALSE"

Expand Down