[Internal] Rewrite databricks_job data source to use Go SDK
#5078
+689
−1,430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this refactoring we'll fix a problem when a job has more than 100 tasks - current implementation won't handle it correctly. Plus, it won't work in the workspaces with a lot of jobs... Also, refactored job tests to use Mock API instead of `HTTPFixture`.
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the databricks_job data source to use the Go SDK instead of the legacy APIs, fixing pagination issues for workspaces with more than 100 jobs and improving support for jobs with more than 100 tasks. The changes also migrate job tests from HTTPFixtures to the Mock API pattern for better maintainability.
Key Changes:
- Migrated data source from legacy API to Go SDK with proper pagination support
- Refactored all job tests to use Mock API instead of HTTPFixture pattern
- Removed legacy API functions like
ListByNameandListmethods - Fixed git source schema conflicts with proper prefix handling
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
jobs/data_job.go |
Core data source refactoring to use Go SDK with improved job listing and retrieval |
jobs/data_job_test.go |
Complete test migration from HTTPFixture to Mock API pattern |
jobs/resource_job.go |
Removed legacy API methods and fixed git source schema conflicts |
jobs/resource_job_test.go |
Extensive test refactoring using Mock API for better test isolation |
jobs/resource_job_webhook_test.go |
Updated webhook notification tests to use Mock API |
NEXT_CHANGELOG.md |
Added changelog entry for the refactoring |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this refactoring, we'll fix a problem that occurs when a job has more than 100 tasks - the current implementation does not handle it correctly. Additionally, it won't work in workspaces with a large number of jobs...
Additionally, I refactored job tests to use the Mock API instead of
HTTPFixture. And started to remove unnecessary functions for legacy Jobs APIs.Tests
make testrun locallydocs/folderinternal/acceptanceNEXT_CHANGELOG.mdfile