Skip to content

Conversation

@tanmay-db
Copy link
Contributor

Changes

Panic scenario on main branch

Tests

Integration test

@tanmay-db tanmay-db requested review from a team as code owners October 8, 2025 14:55
@tanmay-db tanmay-db requested review from Tejas-Kochar and removed request for a team October 8, 2025 14:55
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes.
If this is not necessary for your PR, please include the following in your PR description:
NO_CHANGELOG=true
and rerun the job.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 5084
  • Commit SHA: 0186426125928f212073cf4bb28975f0980744bc

Checks will be approved automatically on success.

@tanmay-db tanmay-db removed request for a team and Tejas-Kochar October 8, 2025 14:58
@tanmay-db tanmay-db changed the title [TEST] [DO NOT MERGE] Test for panic in share resource (pluginfw) [TEST] [DO NOT MERGE] E2E Test for panic in share resource (pluginfw) Oct 8, 2025
github-merge-queue bot pushed a commit that referenced this pull request Oct 14, 2025
…ation of share resource (#4969)

## Changes
<!-- Summary of your changes that are easy to understand -->
Planned objects can be less than the state objects. This can happen when
someone removes an object in share resource outside the terraform (for
example through UI). The changes fixes the syncing of effective fields
by making sure we iterate over the planned and state objects properly.

Ref:
#4913

## Tests
<!--
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->
Integration tests
- Test panics over main (before these changes):
#5084
- Test passes on the changes in this PR.

Unit tests
- Tests panics before the changes
([ref](#4970)):
<img width="1227" height="590" alt="image"
src="https://github.com/user-attachments/assets/1268effa-41ae-44be-9f2a-c0df08cc12e2"
/>
- Tests passes over the changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants