[Internal] Ported databricks_instance_pool data source to plugin framework and Go SDK
#5145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amework Migrated the instance pool data source from SDKv2 to Terraform Plugin Framework using the Databricks Go SDK. Changes: - Created new plugin framework implementation in internal/providers/pluginfw/products/pools/ - data_instance_pool.go: Main data source implementation using w.InstancePools.GetByInstancePoolName() - data_instance_pool_test.go: Unit tests - data_instance_pool_acc_test.go: Acceptance tests - Removed old SDKv2 implementation from pools/ - pools/data_instance_pool.go - pools/data_instance_pool_test.go - Registered data source in pluginfw_rollout_utils.go as pluginFwOnlyDataSources - Removed SDKv2 registration from internal/providers/sdkv2/sdkv2.go Implementation details: - Uses Go SDK's GetByInstancePoolName() for efficient lookup - Schema includes 'id' (computed, set to pool ID) and 'pool_info' (object type) - Maintains backward compatibility with SDKv2 schema structure - Uses production name: databricks_instance_pool
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
changed the title
databricks_instance_pool data source to plugin frameworkdatabricks_instance_pool data source to plugin framework and Go SDK
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Migrated the instance pool data source from SDKv2 to Terraform Plugin Framework using the Databricks Go SDK. The change is relatively low risk, so just went with direct implementation without fallback
Changes:
Implementation details:
Tests
make testrun locallyrelevant change indocs/folderinternal/acceptanceNEXT_CHANGELOG.mdfile