Skip to content

Conversation

@anupkalburgi
Copy link
Collaborator

Changes

Linked issues

Resolves #..

Requirements

  • manually tested
  • updated documentation
  • updated demos
  • updated tests

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 53.44262% with 142 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@3aca7f3). Learn more about missing BASE report.
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
dbldatagen/spec/generator_spec_impl.py 0.00% 111 Missing ⚠️
dbldatagen/spec/generator_spec.py 84.21% 13 Missing and 2 partials ⚠️
dbldatagen/spec/__init__.py 28.57% 10 Missing ⚠️
dbldatagen/spec/output_targets.py 85.18% 3 Missing and 1 partial ⚠️
dbldatagen/spec/compat.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #372   +/-   ##
=========================================
  Coverage          ?   89.41%           
=========================================
  Files             ?       53           
  Lines             ?     4450           
  Branches          ?      809           
=========================================
  Hits              ?     3979           
  Misses            ?      325           
  Partials          ?      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 139 to 142
class ValidationResult:
"""Container for validation results that collects errors and warnings during spec validation.

This class accumulates validation issues found while checking a DatagenSpec configuration.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move it out, a diff module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants