Crest v1.4.1 code changes#51
Conversation
|
|
There was a problem hiding this comment.
PR Overview
This PR updates the Crest add-on to version 1.4.1 by introducing a threading mechanism for faster query result fetching and automating the start of the Databricks Warehouse during query execution. Additional configuration parameters have been added and documentation updated to reflect these enhancements.
Reviewed Changes
| File | Description |
|---|---|
| app/appserver/static/cancel_button.js | Adds cancel run UI functionality with error handling and success pop-ups. |
| app/README.md | Updates release notes, version numbers, and documentation for configuration changes. |
| app/appserver/static/js/build/custom/auth_select_hook.js | Enhances field toggling logic based on the dbquery configuration. |
| app/README/ta_databricks_settings.conf.spec | Adds an [additional_parameters] section for new configuration parameters. |
| app/README/ta_databricks_account.conf.spec | Introduces new keys for configuring Databricks query settings. |
| app/README/alert_actions.conf.spec | Revises parameter descriptions for the launch_notebook alert action. |
Copilot reviewed 83 out of 83 changed files in this pull request and generated 3 comments.
|
|
||
| var runDetailsTable = mvc.Components.get("databricks_run_table"); | ||
| var jobDetailsTable = mvc.Components.get("databricks_job_table"); | ||
| customRenderer = TableView.BaseCellRenderer.extend({ |
There was a problem hiding this comment.
Declare 'customRenderer' using var, let, or const to avoid polluting the global namespace.
| customRenderer = TableView.BaseCellRenderer.extend({ | |
| var customRenderer = TableView.BaseCellRenderer.extend({ |
| var run_ex_status = array[2]; | ||
|
|
||
| if(run_ex_status !== "Running" && run_ex_status !== "Initiated" && run_ex_status !== "Pending"){ | ||
| $td.html("<div class='ar_containter'><div class='cancel_button_disabled' value='Cancel'>Cancel Run</div></div>"); |
There was a problem hiding this comment.
[nitpick] Typo in the CSS class name 'ar_containter'; consider correcting it to 'ar_container' for clarity.
| $td.html("<div class='ar_containter'><div class='cancel_button_disabled' value='Cancel'>Cancel Run</div></div>"); | |
| $td.html("<div class='ar_container'><div class='cancel_button_disabled' value='Cancel'>Cancel Run</div></div>"); |
| * Minor bugfix. | ||
|
|
||
| # RELEASE NOTES VERSION 1.4.0 | ||
| * Introduced threading mechanism to fetch query results faster. Thread count can be configured from 'Addidtional Parameters' page. |
There was a problem hiding this comment.
Typo in 'Addidtional Parameters'; please change it to 'Additional Parameters'.
| * Introduced threading mechanism to fetch query results faster. Thread count can be configured from 'Addidtional Parameters' page. | |
| * Introduced threading mechanism to fetch query results faster. Thread count can be configured from 'Additional Parameters' page. |
|
@dhruvilbhatt-crest can you sign the CLA - it's required to merge the PR |
|
Hi @alexott I just signed the CLA, but it looks like it's taking some time to reflect. 
|
|
Yes, as I remember it takes some time. Can you also check comments & suggestions from Copilot? |
|
Superseded by #56 |
Crest v1.4.1 code changes