Skip to content

Add N9300 switch memory check#370

Open
Priyanka-Patil14 wants to merge 9 commits intodatacenter:v4.1.0-devfrom
Priyanka-Patil14:feature/n9300-switch-memory-check
Open

Add N9300 switch memory check#370
Priyanka-Patil14 wants to merge 9 commits intodatacenter:v4.1.0-devfrom
Priyanka-Patil14:feature/n9300-switch-memory-check

Conversation

@Priyanka-Patil14
Copy link
Copy Markdown

Summary

This PR adds a new validation check: N9300 Switch Memory.

The check runs only when the target upgrade version is 6.1 and validates that N9300-series switches have at least 24 GB memory before upgrade.

What Changed

  • Added n9300_switch_memory_check in aci-preupgrade-validation-script.py
  • Added validation documentation in docs/docs/validations.md
  • Added dedicated unit tests and test data under:
    • tests/checks/n9300_switch_memory_24g_check/

Check Behavior

  • Returns MANUAL if target version is missing
  • Returns N/A if target version is not 6.1
  • Returns N/A if no N9300 switches are present
  • Returns FAIL_O for N9300 nodes with memory < 24 GB
  • Returns PASS when all applicable N9300 nodes have >= 24 GB

##Test Validation
Executed:
pytest tests/checks/n9300_switch_memory_24g_check/test_n9300_switch_memory_24g_check.py -q

Result:
7 passed in 0.11s

No failures observed.

Copy link
Copy Markdown

@Harinadh-Saladi Harinadh-Saladi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls address the comments

@asraf-khan
Copy link
Copy Markdown

@Priyanka-Patil14 please attach test result from APIC for possible scenario's

@Priyanka-Patil14
Copy link
Copy Markdown
Author

Memory_Check_logs.docx

Uploaded the logs.

@asraf-khan
Copy link
Copy Markdown

@Priyanka-Patil14 can you please provide updated script output from APIC and error handling cases?

@Priyanka-Patil14
Copy link
Copy Markdown
Author

Priyanka-Patil14 commented Mar 24, 2026

@Priyanka-Patil14 can you please provide updated script output from APIC and error handling cases?

MemoryCheck_Logs.txt
APIC_Output_Logs.txt

Uploaded the logs. Please review it.

@Priyanka-Patil14 Priyanka-Patil14 changed the base branch from master to v4.1.0-dev April 9, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants