Add Bearer API key authentication for MDS endpoints#91
Open
kaysiz wants to merge 2 commits into
Open
Conversation
Accept Authorization: Bearer tokens alongside Basic auth on DOI, media, and metadata routes, and forward credentials to the DataCite API via Maremma. Extract shared auth logic into ApiAuthenticatable to centralize Maremma credential handling, client relationships for Basic auth, and missing-auth responses. Add WebMock and request specs to verify bearer tokens are accepted and forwarded.
Align with lupo API key authentication by allowing requests where the API key is sent as the Basic username with no password (e.g. curl --user DC.xxx:). Forward credentials to the DataCite API and omit client relationships when the username is an API key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add Bearer API key authentication for MDS endpoints
closes: Add github issue that originated this PR
Approach
Add Bearer API key authentication for MDS endpoints
Accept Authorization: Bearer tokens alongside Basic auth on DOI, media,
and metadata routes, and forward credentials to the DataCite API via Maremma.
Extract shared auth logic into ApiAuthenticatable to centralize Maremma
credential handling, client relationships for Basic auth, and missing-auth
responses. Add WebMock and request specs to verify bearer tokens are accepted
and forwarded.
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: