-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(ui/incident): Change for showing the custom type and note #13056
Merged
jjoyce0510
merged 13 commits into
datahub-project:master
from
amit-apptware:ag--fix/show-custom-type-on-incident
Apr 9, 2025
Merged
Fix(ui/incident): Change for showing the custom type and note #13056
jjoyce0510
merged 13 commits into
datahub-project:master
from
amit-apptware:ag--fix/show-custom-type-on-incident
Apr 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Apr 3, 2025
...-web-react/src/app/entityV2/shared/tabs/Incident/AcrylComponents/IncidentActivityContent.tsx
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Apr 3, 2025
datahub-web-react/src/app/entityV2/shared/tabs/Incident/AcrylComponents/IncidentView.tsx
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Apr 3, 2025
datahub-web-react/src/app/entityV2/shared/tabs/Incident/AcrylComponents/styledComponents.tsx
Show resolved
Hide resolved
jjoyce0510
reviewed
Apr 3, 2025
datahub-web-react/src/app/entityV2/shared/tabs/Incident/hooks.tsx
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Apr 3, 2025
datahub-web-react/src/app/entityV2/shared/tabs/Incident/utils.tsx
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Apr 3, 2025
datahub-web-react/src/app/entityV2/shared/tabs/Incident/utils.tsx
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Apr 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking really good. Just a few minor comments to address.
jjoyce0510
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
product
PR or Issue related to the DataHub UI/UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.2025-04-03.12-34-22.webm
Screencast for updating the incidents -
Screencast from 2025-04-09 07-06-00.webm
Test Cases
Tested with below scenarios on OSS for adding incident with custom type:
Checklist