Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(ui/incident): Change for showing the custom type and note #13056

Conversation

amit-apptware
Copy link
Contributor

@amit-apptware amit-apptware commented Apr 2, 2025

Screencast.from.2025-04-03.12-34-22.webm

Screencast for updating the incidents -
Screencast from 2025-04-09 07-06-00.webm

Test Cases

Tested with below scenarios on OSS for adding incident with custom type:

  • The incident table columns with custom category
  • The incident table group headers should show custom category (when grouping by type)
  • The incident table filters needs to show custom category options (when trying to filter by category)
  • The incident "view" modal should show custom category
  • Added default value for the resolution pop up
  • Added resolution note underneath the time in activity log section
  • Change the type to category for the filter and group by
  • Add hover effect on group row of the table

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Apr 2, 2025
@amit-apptware amit-apptware marked this pull request as ready for review April 2, 2025 14:35
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Apr 2, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Apr 3, 2025
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking really good. Just a few minor comments to address.

@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Apr 3, 2025
@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Apr 9, 2025
@jjoyce0510 jjoyce0510 merged commit 7d9d8b9 into datahub-project:master Apr 9, 2025
76 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants