Skip to content

feat(ui) Use new Tabs component on entity profile pages #13640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

chriscollins3456
Copy link
Collaborator

This PR updates the entity profile page tabs to use our new tabs component for consistency and cleaner styles. In order to make this work, I had to factor in the existing functionality around these tabs such as showing a count for certain tabs and pass that into the tabs component. Additionally I had to support showing disabled tabs as well.

Overall this should be a relatively clean swap out but would really appreciate someone pulling down and doing some manual testing themselves.

Here's what it looks like now:
image

image

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label May 27, 2025
Copy link

alwaysmeticulous bot commented May 27, 2025

🔴 Meticulous spotted visual differences in 590 of 1373 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit 7c5302b. This comment will update as new commits are pushed.

Copy link

codecov bot commented May 27, 2025

Bundle Report

Changes will decrease total bundle size by 1.96kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 19.65MB -1.96kB (-0.01%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -1.96kB 16.02MB -0.01%

Files in assets/index-*.js:

  • ./src/app/entityV2/shared/containers/profile/header/EntityTabs.tsx → Total Size: 1.47kB

  • ./src/app/entityV2/dashboard/DashboardEntity.tsx → Total Size: 10.87kB

  • ./src/app/entityV2/dataProduct/DataProductEntity.tsx → Total Size: 6.17kB

  • ./src/app/entityV2/shared/types.ts → Total Size: 791 bytes

  • ./src/app/entity/shared/tabs/Dataset/Governance/GovernanceTab.tsx → Total Size: 2.07kB

  • ./src/app/entityV2/mlModel/MLModelEntity.tsx → Total Size: 5.14kB

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/AcrylValidationsTab.tsx → Total Size: 4.44kB

  • ./src/app/entityV2/dataset/DatasetEntity.tsx → Total Size: 13.78kB

  • ./src/alchemy-components/components/Tabs/Tabs.tsx → Total Size: 2.27kB

  • ./src/app/entityV2/dataFlow/DataFlowEntity.tsx → Total Size: 5.84kB

  • ./src/app/entityV2/mlFeature/MLFeatureEntity.tsx → Total Size: 5.95kB

  • ./src/app/homeV2/content/tabs/CenterTabs.tsx → Total Size: 1.09kB

  • ./src/app/entityV2/domain/DomainEntity.tsx → Total Size: 6.96kB

  • ./src/app/entityV2/dataset/profile/useGetColumnTabCount.ts → Total Size: 234 bytes

  • ./src/app/entityV2/glossaryTerm/GlossaryTermEntity.tsx → Total Size: 5.36kB

  • ./src/app/entityV2/glossaryTerm/profile/useGlossaryRelatedAssetsTabCount.ts → Total Size: 586 bytes

  • ./src/app/entityV2/shared/containers/profile/EntityProfile.tsx → Total Size: 10.09kB

  • ./src/app/entityV2/chart/ChartEntity.tsx → Total Size: 9.62kB

  • ./src/app/entityV2/dataJob/DataJobEntity.tsx → Total Size: 7.99kB

Copy link

codecov bot commented May 27, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
114 1 113 0
View the top 1 failed test(s) by shortest run time
glossaryTerm cypress/e2e/glossaryV2/v2_glossaryTerm.js::cypress/e2e/glossaryV2/v2_glossaryTerm.js
Stack Traces | 16s run time
2025-05-27T22:40:02.142Z
Timed out retrying after 10000ms: Expected to find element: `.anticon.anticon-appstore`, but never found it.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sakethvarma397
Copy link
Contributor

Screenshot 2025-06-03 at 4 20 15 PM Screenshot 2025-06-03 at 4 20 27 PM

The spacing on few tabs became a bit prominent with these changes

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jun 3, 2025
Copy link
Contributor

@sakethvarma397 sakethvarma397 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes locally and they all look good. Just noticed some spacing issues for which I added screenshots in the other comment.

Approving it, but please check the merge conflict and failing CI.

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants