-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(ui) Use new Tabs component on entity profile pages #13640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🔴 Meticulous spotted visual differences in 590 of 1373 screens tested: view and approve differences detected. Meticulous evaluated ~9 hours of user flows against your PR. Last updated for commit 7c5302b. This comment will update as new commits are pushed. |
Bundle ReportChanges will decrease total bundle size by 1.96kB (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested changes locally and they all look good. Just noticed some spacing issues for which I added screenshots in the other comment.
Approving it, but please check the merge conflict and failing CI.
This PR updates the entity profile page tabs to use our new tabs component for consistency and cleaner styles. In order to make this work, I had to factor in the existing functionality around these tabs such as showing a count for certain tabs and pass that into the tabs component. Additionally I had to support showing disabled tabs as well.
Overall this should be a relatively clean swap out but would really appreciate someone pulling down and doing some manual testing themselves.
Here's what it looks like now:
