Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize db model relationships, auth checks #109

Merged
merged 14 commits into from
May 6, 2024

Conversation

bdewilde
Copy link
Member

@bdewilde bdewilde commented May 6, 2024

changes

  • tidies up api v1 init module
  • updates legacy "dynamic" db model relationships to equivalent "write_only" relationships, and updates their usage in api resources accordingly
  • updates various other db model relationships to be more performant and clear
  • adds User.collaborators method, to get all users who work together on shared reviews
  • consolidates some is-allowed checks for api resources... this was more awkward than hoped for, so tbd on if this will expand
  • allows admins to delete users, and updates unit tests accordingly
  • un-skips citation import unit tests

@bdewilde bdewilde changed the base branch from main to develop May 6, 2024 01:54
@bdewilde bdewilde marked this pull request as ready for review May 6, 2024 02:01
@bdewilde bdewilde merged commit 9d97f2c into develop May 6, 2024
3 checks passed
@bdewilde bdewilde deleted the burton-lay-groundwork-api-v2 branch May 6, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant