Skip to content

Conversation

@BenjaminCharmes
Copy link
Contributor

Closes #1385

  • Add ELN export button for individual samples
  • Add modal to export related sample graphs
  • Unify ExportButton component for collections and samples
  • Refactor create_eln_file to handle both collections and samples

@cypress
Copy link

cypress bot commented Oct 30, 2025

datalab    Run #4028

Run Properties:  status check passed Passed #4028  •  git commit 400b2446e9 ℹ️: Merge 8187b86e6adb39ae039b93dabcebd95a32647fd0 into 0103231fd5ac4da4c43f5519a888...
Project datalab
Branch Review bc/eln-button
Run status status check passed Passed #4028
Run duration 07m 52s
Commit git commit 400b2446e9 ℹ️: Merge 8187b86e6adb39ae039b93dabcebd95a32647fd0 into 0103231fd5ac4da4c43f5519a888...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 68.51852% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.45%. Comparing base (3ef27ff) to head (8187b86).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/routes/v0_1/export.py 56.00% 44 Missing ⚠️
pydatalab/src/pydatalab/export_utils.py 76.13% 21 Missing ⚠️
pydatalab/src/pydatalab/scheduler.py 44.11% 19 Missing ⚠️
pydatalab/src/pydatalab/routes/v0_1/graphs.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
- Coverage   80.12%   79.45%   -0.67%     
==========================================
  Files          70       74       +4     
  Lines        4794     5052     +258     
==========================================
+ Hits         3841     4014     +173     
- Misses        953     1038      +85     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/models/export_task.py 100.00% <100.00%> (ø)
pydatalab/src/pydatalab/mongo.py 81.81% <100.00%> (+0.99%) ⬆️
pydatalab/src/pydatalab/routes/v0_1/__init__.py 100.00% <100.00%> (ø)
pydatalab/src/pydatalab/routes/v0_1/graphs.py 97.70% <95.45%> (-1.01%) ⬇️
pydatalab/src/pydatalab/scheduler.py 44.11% <44.11%> (ø)
pydatalab/src/pydatalab/export_utils.py 76.13% <76.13%> (ø)
pydatalab/src/pydatalab/routes/v0_1/export.py 56.00% <56.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review October 30, 2025 14:14
@ml-evs ml-evs moved this to Todo in merge stack Oct 30, 2025
@BenjaminCharmes
Copy link
Contributor Author

BenjaminCharmes commented Oct 30, 2025

  • Export Button/Dropdown in Navbar
  • itemGraph in ExportModal
  • itemGraph depth control (reusable component)

Add itemGraph in ExportModal and depth control for related items

Add itemGraph in ExportModal and depth control for related items

Use slider to control itemGraph depth

Add cypress component tests

Add cypress component tests

Add cypress component tests

Add cypress component tests

Add cypress component tests

Add cypress component tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Further support for ELNFileFormat

4 participants