Skip to content

Fixed misleading message from Remove-FabricWarehouse (#145) #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 18, 2025
Merged

Fixed misleading message from Remove-FabricWarehouse (#145) #152

merged 8 commits into from
Jul 18, 2025

Conversation

NowinskiK
Copy link
Contributor

@NowinskiK NowinskiK commented Jul 16, 2025 •
edited
Loading

Pull Request

Fixed misleading message from Remove-FabricWarehouse (#145)

Pull Request (PR) description

Fixed

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency -Tasks build, test).
  • Comment-based help added/updated.
  • Examples appropriately added/updated.
  • Unit tests added/updated..
  • Integration tests added/updated (where possible).
  • Documentation added/updated (where applicable).
  • Code follows the contribution guidelines.

@NowinskiK NowinskiK linked an issue Jul 16, 2025 that may be closed by this pull request
Remove-FabricWarehouse returns successful message even if delete fails #145
Closed
@NowinskiK NowinskiK marked this pull request as ready for review July 16, 2025 17:28
@github-actions GitHub Actions
Copy link

Linux Test Results

5 085 tests   5 084 ✅  43s ⏱️
  617 suites      1 💤
    1 files        0 ❌

Results for commit fa433e4.

@github-actions GitHub Actions
Copy link

WinPS51 Test Results

5 298 tests   5 297 ✅  50s ⏱️
  618 suites      1 💤
    1 files        0 ❌

Results for commit fa433e4.

@github-actions GitHub Actions
Copy link

WinPS71 Test Results

5 298 tests   5 297 ✅  52s ⏱️
  618 suites      1 💤
    1 files        0 ❌

Results for commit fa433e4.

tiagobalabuch
tiagobalabuch approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@tiagobalabuch tiagobalabuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me

@NowinskiK NowinskiK merged commit 1aacaae into develop Jul 18, 2025
8 checks passed
@NowinskiK NowinskiK deleted the bug/145-Remove-FabricWarehouse branch July 18, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiagobalabuch tiagobalabuch tiagobalabuch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove-FabricWarehouse returns successful message even if delete fails

2 participants

@NowinskiK @tiagobalabuch