Disallow commas in amount input for all devices#292
Open
MaxBerglund wants to merge 1 commit intomasterfrom
Open
Disallow commas in amount input for all devices#292MaxBerglund wants to merge 1 commit intomasterfrom
MaxBerglund wants to merge 1 commit intomasterfrom
Conversation
hfjallborg
requested changes
Mar 8, 2026
Contributor
hfjallborg
left a comment
hfjallborg
left a comment
There was a problem hiding this comment.
Looks good, but I think there's some issue with the oninput callback. I assume it's meant to automatically replace commas with periods, but it's not working for me. I think that it might be an issue with Vue 😓
I think it may be possible to achieve the same result by changing the lang attribute, but I'm not certain it will completely prevent users from typing in commas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #291
Although couldn't test on a Google Pixel 6 Pro myself, so not entirely sure if the issue is completely resolved.