Fixes #111 Memory Effect on TableFilter#126
Merged
toptobes merged 2 commits intodatastax:mainfrom Apr 8, 2026
Merged
Conversation
toptobes
approved these changes
Apr 3, 2026
sl-at-ibm
reviewed
Apr 8, 2026
|
|
||
| // searches with ENTRIES | ||
|
|
||
| // MARK A |
Collaborator
There was a problem hiding this comment.
// MARK A commend can be deleted :)
sl-at-ibm
reviewed
Apr 8, 2026
| ); | ||
| Assert.NotNull(row_full_eB); | ||
| Assert.Equal("base", row_full_eB.id); | ||
| // MARK B |
Collaborator
There was a problem hiding this comment.
// MARK B commend can be deleted :)
sl-at-ibm
reviewed
Apr 8, 2026
| { | ||
| IfNotExists = true | ||
| }); | ||
| await table.CreateIndexAsync("tmp_map_k_idx", (b) => b.map_k, Builders.TableIndex.Map(MapIndexType.Keys), new CreateIndexCommandOptions() |
Collaborator
There was a problem hiding this comment.
Creation of this index, tmp_map_k_idx and of the next one, tmp_map_v_idx, can be omitted since the test only searches by the map_e column. (this test is a shortened form of a longer one, which is why there was more preparation on the table).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.