Enable options to index creation on maps (solves issue 122)#133
Open
Enable options to index creation on maps (solves issue 122)#133
Conversation
…ation; adjust xmldocs to zero warnings
Collaborator
Author
|
@a-random-steve FYI ^ |
toptobes
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122 .
This PR enables passing the options (ascii/normalize/caseSensitive) to index creation for a map table column.
Along the way:
Note: as a matter of fact, the Data API accepts these options when creating keys/values indexes only, whereas for "entries creation" there is only one allowed combination of the three bools (the default), which renders it unnecessary to specify them. However, preventing the user from supplying the options is probably not a task for the client under the philosophy of not duplicating server-side guardrails. Hence no checks are performed ("if mapindextype == entries ...").