HCD-23 Tighten up permissions on system keyspaces #1667
Conversation
Checklist before you submit for review
|
|
Triggered |
|
❌ Build ds-cassandra-pr-gate/PR-1667 rejected by Butler1 new test failure(s) in 1 builds Found 1 new test failures
Found 2 known test failures |
|
On this one you'd need a CNDB PR imo to make sure we don't break anything there? |
| superuser.execute(format("GRANT MODIFY ON ALL KEYSPACES TO %s", user)); | ||
| // User now has write permission on non-system keyspaces only | ||
| nonsuperuser.execute("INSERT INTO user_keyspace.t1 (k) VALUES (0)"); | ||
| /* FIXME: 'User user has no MODIFY permission on <table system_views.local_node> or any of its parents' |
There was a problem hiding this comment.
@tiagomlalves I am not seeing the problem here. If the tables names between OSS and CC changed why not just change the assertion message accordingly. What am I missing?
There was a problem hiding this comment.
The problem is that we're trying to insert into system.local table but error message reports error on system_views.local_node table. Code is translating the table when writing to it but is not translating it for the error message.
Here, I see two solutions:
- accept the message and leave a comment with the follow up ticket
- use a different table with same semantics (happy to accept suggestion on the one to use).
There was a problem hiding this comment.
I am not following 100% but if you accept the current message as it is, when that bug gets eventually fixed this test will fail and the author will fix it as well. I guess there is more value in targeting sensitive ks'.
Backports CASSANDRA-20090: * Restrict which permissions can be granted on system keyspaces * Ensure that GRANT... ON ALL KEYSPACES excludes system keyspaces * Add system_traces to the always readable set
tiagomlalves
force-pushed
the
HCD-23-main
branch
from
0181a55 to
23ce69d
Compare
done! |
|
I've went through the CNDB failures and they don't seem to be related with these changes. I still need to rework the PR to uncomment the tests and accept the exception messages. |
What is the issue
Improves permissions security.
What does this PR fix and why was it fixed
Backports CASSANDRA-20090: