CNDB-13534: Add RequestFailureReason.FEATURE_NEEDS_INDEX_REBUILD

[driftx]

The main difference was porting FeatureNeedsIndexRebuildException.

[djatnieks]

I looked at the test failures reported above by Butler and they all look like known failing or flaky tests on the 5.0 test failure list

I don't think Butler knows how to do a correct comparison with main-5.0 - meaning I think it always compares PR results to main.

One thing, if you didn't do it already, is to run the "verify" script that I think I mentioned previously - it identified all the unit and distributed tests that were touched by the most recent commit and executes them. For a relatively large commit like this, that's my typical method of verifying the port

[djatnieks]

I checked out the branch and got a compile error:

    [javac] /Users/danj/projects/cc-main-5.0/test/unit/org/apache/cassandra/index/sai/disk/v1/kdtree/KDTreeIndexBuilder.java:194: error: cannot find symbol
    [javac]             assertThat(searcher, is(instanceOf(KDTreeIndexSearcher.class)));
    [javac]                                     ^
    [javac]   symbol:   method instanceOf(Class<KDTreeIndexSearcher>)
    [javac]   location: class KDTreeIndexBuilder

Then I realized the CI build has the same error - weird that it ran tests if the build part had a problem 🤷🏻

[driftx]

Then I realized the CI build has the same error - weird that it ran tests if the build part had a problem 🤷🏻

I think that was because your commits got in and caused a small conflict that I resolved in the web interface. I've rebased and pushed it now.

[sonarqubecloud]

Quality Gate failed

Failed conditions
1.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[cassci-bot]

❌ Build ds-cassandra-pr-gate/PR-1781 rejected by Butler

---

103 new test failure(s) in 2 builds
See build details here

---

Found 103 new test failures

Showing only first 15 new test failures

Test	Explanation	Branch history	Upstream history
t.TestCqlshCompletion.test_complete_in_alter_table	regression	🔴🔵
t.TestCqlshCompletion.test_complete_in_alter_type	regression	🔴🔵
t.TestCqlshCompletion.test_complete_in_create_type	regression	🔴🔵
t.TestCqlshCompletion.test_complete_in_drop_type	regression	🔴🔵
t.TestCqlshCompletion.test_complete_in_tracing	regression	🔴🔵
t.TestCqlshOutput.test_blob_output	regression	🔴🔵
t.TestCqlshOutput.test_boolean_output	regression	🔴🔵
...lshOutput.test_expanded_output_counts_past_page	regression	🔴🔵
t.TestCqlshOutput.test_no_prompt_or_colors_output	regression	🔴🔵
t.TestCqlshOutput.test_numeric_output	regression	🔴🔵
t.TestCqlshOutput.test_printing_cql_error	regression	🔴🔵
t.TestCqlshOutput.test_user_types_with_collections	regression	🔴🔵
t.TestCqlshUnicode.test_unicode_multiline_input	regression	🔴🔵
c.t.TestCqlshSmoke.test_copy_stdout	regression	🔴🔵
r.TestAllowFiltering.test_update_on_collection	regression	🔴🔵

---

No known test failures found