Skip to content

CNDB-14301: couple jvector file format and SAI version #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaeljmarshall
Copy link
Member

What is the issue

Fixes: https://github.com/riptano/cndb/issues/14301

What does this PR fix and why was it fixed

Make version EB use jvector file format 4. Also allow for some configurability in earlier versions just in case we have some clusters relying on that behavior.

Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@michaeljmarshall
Copy link
Member Author

Companion CNDB test PR: https://github.com/riptano/cndb/pull/14303

Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1786 rejected by Butler


3 new test failure(s) in 1 builds
See build details here


Found 3 new test failures

Test Explanation Branch history Upstream history
o.a.c.i.s.p.OperationTest.BeforeFirstTest regression 🔴
o.a.c.n.NodesTest.testPeersSerialization regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴 🔵🔵🔵🔵🔵🔵🔵

Found 4 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants