Bun Support #416
Closed
Bun Support #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing how we connect to the net client so runtimes like bun will work (tested this on 1.0.6)
In bun, for some reason when concating buffers if the length is set to undefined, bun returns a empty buffer. This fixes that (still works in node, tested on bun v1.06 and node v16.20.2+)
|
I've also already signed the datastax CLA |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces fixes to support Bun in a project that utilizes cassandra-driver by addressing incompatibilities in buffer concatenation and connection setup.
- Updated Buffer.concat fallback in lib/streams.js to handle an undefined bodyLength.
- Modified net and tls connection initialization in lib/connection.js to use configuration objects and proper port conversion.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/streams.js | Uses a fallback to compute the total buffer length when bodyLength is missing. |
| lib/connection.js | Updates the net and tls connection methods to use an object-based configuration. |
Comments suppressed due to low confidence (1)
lib/connection.js:177
- [nitpick] It may be helpful to add a brief comment on why the connection options are being restructured into an object and the port is being parsed, to provide context for future maintainers.
this.netClient.connect({ host: this.address, port: parseInt(this.port, 10) }, function connectCallback() {
| @@ -289,7 +289,7 @@ Parser.prototype.addFrameBuffer = function (frameInfo, item) { | |||
| */ | |||
| Parser.prototype.getFrameBuffer = function (frameInfo, item) { | |||
| frameInfo.buffers.push(item.chunk); | |||
There was a problem hiding this comment.
Consider adding a comment to explain the fallback logic for the bodyLength computation to improve maintainability and ease future code reviews.
Suggested change
| frameInfo.buffers.push(item.chunk); | |
| frameInfo.buffers.push(item.chunk); | |
| // If frameInfo.bodyLength is undefined, fall back to summing the lengths of all buffers. | |
| // This ensures we correctly compute the total length of the concatenated buffers. |
Copilot uses AI. Check for mistakes.
|
These changes should no longer be needed for latest versions of bun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I'm using bun for one of my projects. I'm also using cassandra-driver. These are a few issues which cause the driver to not work with bun. I've gone ahead and fixed them.
I tested this on bun version 1.0.6, With that I also tested with node v16.20.2+